-
Notifications
You must be signed in to change notification settings - Fork 354
/
findbugs-exclude-filter.xml
316 lines (299 loc) · 12.9 KB
/
findbugs-exclude-filter.xml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
<?xml version="1.0"?>
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!--
This file contains some false positive bugs detected by findbugs. Their
false positive nature has been analyzed individually and they have been
put here to instruct findbugs it must ignore them.
-->
<FindBugsFilter>
<!-- the following equality tests are part of the reference algorithms -->
<!-- which already know about limited precision of the double numbers -->
<Match>
<Class name="org.apache.commons.math4.analysis.solvers.BaseSecantSolver" />
<Method name="doSolve" params="" returns="double" />
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<Match>
<Class name="org.apache.commons.math4.distribution.SaddlePointExpansion" />
<Or>
<Method name="getDeviancePart" params="double,double" returns="double" />
<Method name="getStirlingError" params="double" returns="double" />
</Or>
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<Match>
<Class name="org.apache.commons.math4.optim.univariate.BrentOptimizer" />
<Method name="localMin" params="boolean,double,double,double,double,double" returns="double" />
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<Match>
<Class name="org.apache.commons.math4.analysis.solvers.BrentSolver" />
<Method name="brent" params="double,double,double,double" returns="double" />
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<Match>
<Class name="org.apache.commons.math4.analysis.solvers.MullerSolver" />
<Or>
<Method name="solve" params="double,double,double,double" returns="double" />
</Or>
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<Match>
<Class name="org.apache.commons.math4.analysis.solvers.MullerSolver2" />
<Or>
<Method name="doSolve" params="" returns="double" />
</Or>
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<Match>
<Class name="org.apache.commons.math4.linear.EigenDecomposition" />
<Method name="findEigenVectors" params="double[][]" returns="void" />
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<Match>
<Class name="org.apache.commons.math4.optim.nonlinear.scalar.noderiv.BOBYQAOptimizer" />
<Method name="altmov" params="int,double" returns="double[]" />
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<Match>
<Class name="org.apache.commons.math4.optim.nonlinear.scalar.noderiv.CMAESOptimizer" />
<Method name="doOptimize" params="" returns="org.apache.commons.math4.optim.PointValuePair" />
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<!-- The following equality test is intentional and needed for semantic purposes -->
<Match>
<Or>
<Class name="org.apache.commons.math4.geometry.euclidean.oned.Vector1D" />
<Class name="org.apache.commons.math4.geometry.euclidean.twod.Vector2D" />
<Class name="org.apache.commons.math4.geometry.euclidean.threed.Vector3D" />
</Or>
<Method name="equals" params="java.lang.Object" returns="boolean" />
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<Match>
<Class name="org.apache.commons.math4.optim.linear.LinearConstraint" />
<Method name="equals" params="java.lang.Object" returns="boolean" />
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<!-- The following equality test is intentional and needed for rounding purposes -->
<Match>
<Class name="org.apache.commons.math4.util.Precision" />
<Method name="roundUnscaled" params="double,double,int" returns="double" />
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<!-- The following equality test is intentional for division protection -->
<Match>
<Class name="org.apache.commons.math4.analysis.interpolation.LoessInterpolator" />
<Method name="smooth" params="double[],double[]" returns="double[]" />
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<!-- The following equality test is intentional for infinity detection -->
<Match>
<Class name="org.apache.commons.math4.util.FastMath" />
<Method name="atan2" params="double,double" returns="double" />
<Bug pattern="FE_FLOATING_POINT_EQUALITY" />
</Match>
<!-- The following switch fall-through are due to conversion from FORTRAN goto,
which are handled by a state integer representing the target labels of the goto.
In the original code, this is sequential and fall-through is expected
-->
<Match>
<Class name="org.apache.commons.math4.optim.nonlinear.scalar.noderiv.BOBYQAOptimizer" />
<Or>
<Method name="bobyqb" params="double[],double[]" returns="double" />
<Method name="trsbox" />
</Or>
<Bug pattern="SF_SWITCH_FALLTHROUGH" />
</Match>
<!-- Spurious: Findbugs confused by final local variables -->
<Match>
<Class name="org.apache.commons.math4.util.FastMath" />
<Method name="atan" params="double,double,boolean" returns="double" />
<Bug pattern="DLS_DEAD_LOCAL_STORE" />
</Match>
<!-- the following expositions of internal representation are intentional and documented -->
<Match>
<Class name="org.apache.commons.math4.stat.regression.RegressionResults"/>
<Method name="<init>" params="double[],double[][],boolean,long,int,double,double,double,boolean,boolean" returns="void" />
<Bug pattern="EI_EXPOSE_REP2" />
</Match>
<Match>
<Class name="org.apache.commons.math4.stat.descriptive.AbstractUnivariateStatistic"/>
<Method name="getDataRef" params="" returns="double[]" />
<Bug pattern="EI_EXPOSE_REP" />
</Match>
<Match>
<Class name="org.apache.commons.math4.optim.PointValuePair"/>
<Method name="getPointRef" params="" returns="double[]" />
<Bug pattern="EI_EXPOSE_REP" />
</Match>
<Match>
<Class name="org.apache.commons.math4.optim.PointValuePair"/>
<Method name="<init>" params="double[],double,boolean" returns="void" />
<Bug pattern="EI_EXPOSE_REP2" />
</Match>
<!-- Serialization is handled by an internal class -->
<Match>
<Or>
<Class name="org.apache.commons.math4.optim.PointValuePair"/>
<Class name="org.apache.commons.math4.optim.PointVectorValuePair"/>
</Or>
<Bug pattern="SE_NO_SUITABLE_CONSTRUCTOR" />
</Match>
<Match>
<Class name="org.apache.commons.math4.optim.PointVectorValuePair"/>
<Or>
<Method name="getPointRef" params="" returns="double[]" />
<Method name="getValueRef" params="" returns="double[]" />
</Or>
<Bug pattern="EI_EXPOSE_REP" />
</Match>
<Match>
<Class name="org.apache.commons.math4.optim.PointVectorValuePair"/>
<Method name="<init>" params="double[],double[][],boolean" returns="void" />
<Bug pattern="EI_EXPOSE_REP2" />
</Match>
<Match>
<Class name="org.apache.commons.math4.ode.sampling.DummyStepInterpolator"/>
<Method name="<init>" params="double[],double[],boolean" returns="void" />
<Bug pattern="EI_EXPOSE_REP2" />
</Match>
<Match>
<Class name="org.apache.commons.math4.ode.sampling.AbstractStepInterpolator"/>
<Or>
<Method name="getInterpolatedState" params="" returns="double[]" />
<Method name="getInterpolatedDerivatives" params="" returns="double[]" />
</Or>
<Bug pattern="EI_EXPOSE_REP" />
</Match>
<Match>
<Class name="org.apache.commons.math4.ode.sampling.NordsieckStepInterpolator"/>
<Method name="reinitialize" params="double,double,double[],org.apache.commons.math4.linear.Array2DRowRealMatrix" returns="void" />
<Bug pattern="EI_EXPOSE_REP2" />
</Match>
<Match>
<Class name="org.apache.commons.math4.ode.sampling.NordsieckStepInterpolator"/>
<Method name="getInterpolatedStateVariation" params="" returns="double[]" />
<Bug pattern="EI_EXPOSE_REP" />
</Match>
<Match>
<Class name="org.apache.commons.math4.linear.Array2DRowRealMatrix"/>
<Method name="<init>" params="double[][],boolean" returns="void" />
<Bug pattern="EI_EXPOSE_REP2" />
</Match>
<Match>
<Class name="org.apache.commons.math4.linear.Array2DRowRealMatrix"/>
<Method name="getDataRef" params="" returns="double[][]" />
<Bug pattern="EI_EXPOSE_REP" />
</Match>
<Match>
<Class name="org.apache.commons.math4.linear.BlockFieldMatrix"/>
<Method name="<init>" params="int,int,org.apache.commons.math4.FieldElement[][],boolean" returns="void" />
<Bug pattern="EI_EXPOSE_REP2" />
</Match>
<Match>
<Class name="org.apache.commons.math4.linear.Array2DRowFieldMatrix"/>
<Method name="<init>" params="org.apache.commons.math4.Field,org.apache.commons.math4.FieldElement[][],boolean" returns="void" />
<Bug pattern="EI_EXPOSE_REP2" />
</Match>
<Match>
<Class name="org.apache.commons.math4.linear.Array2DRowFieldMatrix"/>
<Method name="getDataRef" params="" returns="org.apache.commons.math4.FieldElement[][]" />
<Bug pattern="EI_EXPOSE_REP" />
</Match>
<Match>
<Class name="org.apache.commons.math4.linear.BlockRealMatrix"/>
<Method name="<init>" params="int,int,double[][],boolean" returns="void" />
<Bug pattern="EI_EXPOSE_REP2" />
</Match>
<Match>
<Class name="org.apache.commons.math4.util.ResizableDoubleArray"/>
<Or>
<Method name="getValues" params="" returns="double[]" />
<Method name="getInternalValues" params="" returns="double[]" />
</Or>
<Bug pattern="EI_EXPOSE_REP" />
</Match>
<Match>
<Class name="org.apache.commons.math4.linear.ArrayRealVector"/>
<Method name="getDataRef" params="" returns="double[]" />
<Bug pattern="EI_EXPOSE_REP" />
</Match>
<Match>
<Class name="org.apache.commons.math4.linear.ArrayFieldVector"/>
<Method name="getDataRef" params="" returns="org.apache.commons.math4.FieldElement[]" />
<Bug pattern="EI_EXPOSE_REP" />
</Match>
<Match>
<Class name="org.apache.commons.math4.linear.DiagonalMatrix"/>
<Method name="getDataRef" params="" returns="double[]" />
<Bug pattern="EI_EXPOSE_REP" />
</Match>
<!-- The equals method for RealVector intentionally throws an exception -->
<Match>
<Class name="org.apache.commons.math4.linear.RealVector"/>
<Bug pattern="EQ_UNUSUAL" />
</Match>
<Match>
<Class name="org.apache.commons.math4.ml.clustering.DoublePoint"/>
<Method name="<init>" params="double[]" returns="void" />
<Bug pattern="EI_EXPOSE_REP2" />
</Match>
<Match>
<Class name="org.apache.commons.math4.ml.clustering.DoublePoint"/>
<Method name="getPoint" params="" returns="double[]" />
<Bug pattern="EI_EXPOSE_REP" />
</Match>
<!-- The following cases are intentional unit tests for null parameters -->
<Match>
<Class name="org.apache.commons.math4.stat.StatUtilsTest" />
<Method name="testPercentile" params="" returns="void" />
<Bug pattern="NP_NULL_PARAM_DEREF_NONVIRTUAL" />
</Match>
<Match>
<Class name="org.apache.commons.math4.analysis.UnivariateRealSolverFactoryImplTest" />
<Method name="testNewNewtonSolverNull" params="" returns="void" />
<Bug pattern="NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS" />
</Match>
<Match>
<Class name="org.apache.commons.math4.stat.regression.OLSMultipleLinearRegressionTest" />
<Method name="cannotAddNullYSampleData" params="" returns="void" />
<Bug pattern="NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS" />
</Match>
<!-- IntDoublePair intentionally implements Comparable inconsistently with equals -->
<Match>
<Class name="org.apache.commons.math4.stat.ranking.NaturalRanking$IntDoublePair" />
<Bug pattern="EQ_COMPARETO_USE_OBJECT_EQUALS" />
</Match>
<!-- False positive warning from findbugs, the integer division result cast to double is correct here -->
<Match>
<Class name="org.apache.commons.math4.stat.inference.MannWhitneyUTest" />
<Method name="mannWhitneyU" params="double[],double[]" returns="double" />
<Bug pattern="ICAST_IDIV_CAST_TO_DOUBLE" />
</Match>
<!-- The following switch fall-through is intended. -->
<Match>
<Class name="org.apache.commons.math4.ml.neuralnet.twod.NeuronSquareMesh2D" />
<Method name="createLinks" />
<Bug pattern="SF_SWITCH_FALLTHROUGH" />
</Match>
<!-- Integer division results cast to double are intentional. -->
<Match>
<Class name="org.apache.commons.math4.special.BesselJ" />
<Method name="rjBesl" />
<Bug pattern="ICAST_IDIV_CAST_TO_DOUBLE" />
</Match>
</FindBugsFilter>