Merge 84a8400 into 771a218

apache · Aug 6, 2021 · ed73633 · ed73633
2 parents 771a218 + 84a8400
commit ed73633
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 15 deletions.
diff --git a/...-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/jdkmath/AccurateMath.java b/...-legacy-core/src/main/java/org/apache/commons/math4/legacy/core/jdkmath/AccurateMath.java
@@ -2792,9 +2792,7 @@ public static double atan2(double y, double x) {
         }
 
         // Call atan
-        final double result = atan(ra, rb, x < 0);
-
-        return result;
+        return atan(ra, rb, x < 0);
     }
 
     /** Compute the arc sine of a number.

diff --git a/...rc/main/java/org/apache/commons/math4/legacy/analysis/differentiation/SparseGradient.java b/...rc/main/java/org/apache/commons/math4/legacy/analysis/differentiation/SparseGradient.java
@@ -178,8 +178,7 @@ public void addInPlace(final SparseGradient a) {
     /** {@inheritDoc} */
     @Override
     public SparseGradient add(final double c) {
-        final SparseGradient out = new SparseGradient(value + c, derivatives);
-        return out;
+        return new SparseGradient(value + c, derivatives);
     }
 
     /** {@inheritDoc} */

diff --git a/...mons/math4/legacy/analysis/interpolation/PiecewiseBicubicSplineInterpolatingFunction.java b/...mons/math4/legacy/analysis/interpolation/PiecewiseBicubicSplineInterpolatingFunction.java
@@ -142,9 +142,7 @@ public double value(double x,
 
         final PolynomialSplineFunction spline = interpolator.interpolate(yArray, interpArray);
 
-        double returnValue = spline.value(y);
-
-        return returnValue;
+        return spline.value(y);
     }
 
     /**

diff --git a/...ns-math-legacy/src/main/java/org/apache/commons/math4/legacy/genetics/BinaryMutation.java b/...ns-math-legacy/src/main/java/org/apache/commons/math4/legacy/genetics/BinaryMutation.java
@@ -50,8 +50,7 @@ public Chromosome mutate(Chromosome original) throws MathIllegalArgumentExceptio
         // and change it
         newRepr.set(geneIndex, origChrom.getRepresentation().get(geneIndex) == 0 ? 1 : 0);
 
-        Chromosome newChrom = origChrom.newFixedLengthChromosome(newRepr);
-        return newChrom;
+        return origChrom.newFixedLengthChromosome(newRepr);
     }
 
 }
diff --git a/...gacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/LineSearch.java b/...gacy/src/main/java/org/apache/commons/math4/legacy/optim/nonlinear/scalar/LineSearch.java
@@ -119,8 +119,7 @@ public double value(double alpha) {
                 for (int i = 0; i < n; i++) {
                     x[i] = startPoint[i] + alpha * direction[i];
                 }
-                final double obj = mainOptimizer.computeObjectiveValue(x);
-                return obj;
+                return mainOptimizer.computeObjectiveValue(x);
             }
         };
 

diff --git a/...y/src/main/java/org/apache/commons/math4/legacy/stat/inference/KolmogorovSmirnovTest.java b/...y/src/main/java/org/apache/commons/math4/legacy/stat/inference/KolmogorovSmirnovTest.java
@@ -961,9 +961,7 @@ public double exactP(double d, int n, int m, boolean strict) {
      *         \(D_{n,m}\) greater than {@code d}
      */
     public double approximateP(double d, int n, int m) {
-        final double dm = m;
-        final double dn = n;
-        return 1 - ksSum(d * AccurateMath.sqrt((dm * dn) / (dm + dn)),
+        return 1 - ksSum(d * AccurateMath.sqrt(((double) m * (double) n) / ((double) m + (double) n)),
                          KS_SUM_CAUCHY_CRITERION, MAXIMUM_PARTIAL_SUM_COUNT);
     }