MATH-1572 - Simplify Conditions: #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arturobernalg
commented
Apr 13, 2021
arturobernalg
commented
- Simplifiable boolean expression
- Simplifiable conditional expression
- Redundant 'if' statement
* Simplifiable boolean expression * Simplifiable conditional expression * Redundant 'if' statement
msrocka
reviewed
Apr 30, 2021
| } | ||
|
|
||
| return true; | ||
| return values.length != x.length + y.length; // There are no ties. |
There was a problem hiding this comment.
The comment is then wrong, isn't it? Before it checked if there are no ties (values.length == x.length + y.length) and the comment was related to the false return value. Now it directly checks if there are ties which is basically the name of the method so that the comment could be simply removed, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.