MATH-1572: Simplify conditional expressions #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arturobernalg
commented
Aug 5, 2021
arturobernalg
commented
- Simplify bitwise
- Simplify boolean expression
- Simplify conditional expression
- Redundant 'if' statement
aherbert
requested changes
Aug 5, 2021
| @@ -187,10 +187,7 @@ public int compare(WeightedObservedPoint p1, | |||
| return comp; | |||
| } | |||
| comp = Double.compare(p1.getWeight(), p2.getWeight()); | |||
There was a problem hiding this comment.
No need to store the result in comp. Just return the result direct.
There was a problem hiding this comment.
yes, inline variable.
TY
* Simplify boolean expression * Simplify conditional expression * Redundant 'if' statement
aherbert
changed the title
|
This is all fine. Can you update the commit message to prefix with MATH-1572. |
|
Closed by commit 1c8d8da |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.