MATH-1573 - Redundant local variable #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherbert
reviewed
Aug 6, 2021
| //result = result + result * z; | ||
| return result; | ||
| return exp(lna, z, null); |
There was a problem hiding this comment.
I am wondering about the cryptic commented out code here. It would be run after the result has been computed with exp. So if you simply return the result of exp then the comment is before the exp and out of context. I would leave this unchanged until the reason for commenting out the final computation is clarified.
There was a problem hiding this comment.
HI @aherbert
Sound logical. I made rollback of this change.
TY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.