Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented MODE Z for FtpClient #220

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Implemented MODE Z for FtpClient #220

merged 1 commit into from
Feb 24, 2024

Conversation

Flofler
Copy link

@Flofler Flofler commented Feb 20, 2024

I implemented MODE Z for FtpClient to save bandwidth and improve transfer times.

@Flofler
Copy link
Author

Flofler commented Feb 20, 2024

I'm not sure if this is your preferred way to implement this with a wrapping socket. Alternatively I could change any code that is using the getInputStream() and getOutputStream() of the Socket. But then any new code that is using the Socket must know that you will have to wrap an Inflater- or DeflaterOutputStream around it.

Another solution would be to hide the Socket inside a wrapper class completely and only make the getInputStream() and getOutputStream() functions available.

@garydgregory
Copy link
Member

Hi @Flofler

Thank you for your PR.
You should run 'mvn' by itself to run all build checks before you push to catch all errors.

@Flofler
Copy link
Author

Flofler commented Feb 22, 2024

Hi @garydgregory

sorry, I didn't know that. This is my first PR. I fixed all issues and ran 'mvn' by myself and I think it was successful.

@Flofler
Copy link
Author

Flofler commented Feb 22, 2024

I'm not really sure how to fix that problems of the CodeQL check. I also don't think that this problem has anything to do with my changes.

@garydgregory
Copy link
Member

Interesting... it does not look directly related, needs investigating...

@garydgregory
Copy link
Member

Hello @Flofler
Would you please rebase on git master? The CodeQL issues should be resolved.

Copy link

codecov bot commented Feb 23, 2024

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@Flofler
Copy link
Author

Flofler commented Feb 23, 2024

Hi @garydgregory I succesfully rebased on master. You can start the workflows again :)

@garydgregory garydgregory merged commit cf3729a into apache:master Feb 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants