NET-630 Changed SubnetUtils for NEW SubnetInfo #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followed the coding conventions of Apache Commons Net. Improved comments.
The method rangeCheck, pop, and format of SubnetUtils was moved to SubnetInfo in the subnet package. Added asInteger, getCidrSignature, and getAllAddresses methods of SubnetUtils.SubnetInfo to SubnetInfo in the subnet package. Changed the parameter type of isInRange from short array to integer array. Improved comments
IP4Subnet and IP6Subnet were moved to the until package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructors of this class has been modified to create a object of subnet summary information.
Also, added two new static methods to create the object.
Removed the insignificant value representation, which are no reasons to be defined in this class.
Renamed getAddressCount() to getAddressCountString(); the old name, getAddressCount(), was the obsoleted name and confused others.
Improved comments
Changes the path to SubnetInfo (SubnetUtilsExample.java and SubnetUtilsTest.java)
Replaced getAddressCount to getAddressLong in the SubnetUtilsTest class.