NET-685: Update SocketClient default connect timeout from ∞ to 60 seconds

[simo385]

I changed the socket DEFAULT_CONNECT_TIMEOUT value, because, if the server doesn't reply and I don't set the connection timeout, the method FTPClient.connect() hangs infinitely, blocking the whole JVM.

This happens in the multi-threading environment.

Even though there exist the method setConnectTimeout() to set the timeout for Socket, I think a default value should be set-up in order to avoid production breakdown.

Thanks to everybody.
Simone

[garydgregory]

https://issues.apache.org/jira/browse/NET-685

[garydgregory]

@simo385
I am not opposed to the idea but note that SocketClient is an abstract class with many subclasses. I am worried that there are some unintended functional side-effects that this change will cause. Any thoughts from others? I suppose your workaround is to call org.apache.commons.net.SocketClient.setConnectTimeout(int)?

[simo385]

Dear @garydgregory,

yes, currently, the workaround is to call org.apache.commons.net.SocketClient.setConnectTimeout(int), but I've had a lot of problem in my production environment (multi-threading) because of infinity timeout. Also, I've spent a lot of time to find out the issue.

I understand your worry, we can discuss the default timeout value, but IMHO to set a default timeout = infinity is really dangerous, especially in multi-threading environment.

Many thanks for your support.
Simone

[garydgregory]

Since no one has piped up against this and it seems like a good idea, I will merge.