Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-687: Removed creation of SSL socket when opening data connection … #59

Conversation

j-verse
Copy link

@j-verse j-verse commented Sep 11, 2020

…since this is already handled by the socket factory

See Jira ticket for full explanation:
https://issues.apache.org/jira/browse/NET-687

…since this is already handled by the socket factory
@kopavel
Copy link

kopavel commented Sep 17, 2020

Up-vote.
Have the same problem "Unsupported or unrecognized SSL message" using FTPSClient for getting folder content using listFiles method.

@garydgregory
Copy link
Member

We need a test that shows the failure without the main patch. I have part of test I'll commit ASAP...

@garydgregory
Copy link
Member

I added a bare-bones class called org.apache.commons.net.ftp.FTPSClientTest, feel-free to clone/expand to reproduce your error so that anyone can reproduce it.

@garydgregory
Copy link
Member

I can confirm that this PR #59 fixes the regressing bug in Apache Commons VFS master tests in org.apache.commons.vfs2.provider.ftps.test which was introduced by Commons Net 3.7.

@garydgregory
Copy link
Member

@j-verse May you please rebase on master and add a test to FTPSClientTest that shows this failure when the main part of the PR in not applied?

asfgit pushed a commit that referenced this pull request Sep 20, 2020
@garydgregory
Copy link
Member

Fixed in git master along with a new test.

@garydgregory
Copy link
Member

This fix is now available in the 3.7.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants