Simplify boolean expressions with an simpler and equivalent. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arturobernalg
commented
Aug 8, 2021
•
arturobernalg
commented
- Simplify boolean expression with equivalent.
aherbert
reviewed
Aug 8, 2021
| @@ -38,7 +38,7 @@ | |||
| * | |||
| * @param numValues Number of values of the function to compute. | |||
| * @param cache Cached values. | |||
| * @throw IllegalArgumentException if {@code n < 0}. | |||
| * @throw CombinatoricsException if {@code n < 0}. | |||
There was a problem hiding this comment.
CombinatoricsException is package private; it should not be exposed in the javadoc. It extends IllegalArgumentException so the javadoc is still valid.
aherbert
reviewed
Aug 8, 2021
| primeNumbers.add(Integer.valueOf(5)); | ||
| primeNumbers.add(Integer.valueOf(7)); | ||
| primeNumbers.add(Integer.valueOf(11)); | ||
| primeNumbers.add(2); |
There was a problem hiding this comment.
The current code makes the boxing explicit. Please avoid auto-boxing.
aherbert
reviewed
Aug 10, 2021
| @@ -41,7 +41,7 @@ | |||
| * | |||
| * @param numValues Number of values of the function to compute. | |||
| * @param cache Cached values. | |||
| * @throw IllegalArgumentException if {@code n < 0}. | |||
| * @throw CombinatoricsException if {@code n < 0}. | |||
There was a problem hiding this comment.
You have left this CombinatoricsException exposed in the API.
|
This is now only simplifying boolean expressions. Can you update the commit message to reflect that and then correct the formatting as per #103 |
arturobernalg
changed the title
arturobernalg
changed the title
|
You changed the commit message but did not fix formatting to change 8 spaces to 4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.