[COMMONSSITE-156] Reviewing Release Plug-in post Imaging 1.0-alpha3 release #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
force-pushed
the
post-release-improvements
branch
from
d9a1764
to
6d6988b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a few hiccups during the last release of Imaging, so I'm sending this PR to the Release Plug-in, and will prepare a SVN patch for the Commons CMS site.
lang="en"as it's recommended for accessibility)mvn sitedue to a change in the parentThe last part about RAT is a nice to have. At the moment the plug-in is failing to run when you run
mvn site, but it doesn't break the build.The reason is that the RAT plug-in had been using a deprecated call for years, that was eventually removed from the Maven toolkit. Once they release the 0.14 release with the fix it should be fixed. So in other words, at the moment RAT plug-in is not working in the Release Plug-in, but you are able to run
mvn apache-rat:checkandmvn apache-rat:rat.I think this can be merged as-is, and the RAT issue moved to its own issue (or we can downgrade to parent 52)