RNG-81: NumberFactory to sample all rationals between 0 and 1. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherbert
force-pushed
the
improvement-RNG-81
branch
from
a094e93
to
72aa242
Compare
grimreaper
approved these changes
Mar 17, 2019
| Assert.assertEquals(0, (noBits >>> 9) * 0x1.0p-23f, 0); | ||
| Assert.assertEquals(0, (noBits >>> 8) * 0x1.0p-24f, 0); | ||
| Assert.assertEquals(0, Float.intBitsToFloat(0x7f << 23 | noBits >>> 9) - 1.0f, 0); | ||
| Assert.assertEquals(0f, (noBits >>> 9) * 0x1.0p-23f, 0); |
There was a problem hiding this comment.
nitpick: if you're changing the first argument anyways use the canonical form
Suggested change
| Assert.assertEquals(0f, (noBits >>> 9) * 0x1.0p-23f, 0); | |
| Assert.assertEquals(0.0f, (noBits >>> 9) * 0x1.0p-23f, 0); |
| Assert.assertEquals(0, (noBits >>> 8) * 0x1.0p-24f, 0); | ||
| Assert.assertEquals(0, Float.intBitsToFloat(0x7f << 23 | noBits >>> 9) - 1.0f, 0); | ||
| Assert.assertEquals(0f, (noBits >>> 9) * 0x1.0p-23f, 0); | ||
| Assert.assertEquals(0f, (noBits >>> 8) * 0x1.0p-24f, 0); |
There was a problem hiding this comment.
Suggested change
| Assert.assertEquals(0f, (noBits >>> 8) * 0x1.0p-24f, 0); | |
| Assert.assertEquals(0.0f, (noBits >>> 8) * 0x1.0p-24f, 0); |
| Assert.assertEquals(0, Float.intBitsToFloat(0x7f << 23 | noBits >>> 9) - 1.0f, 0); | ||
| Assert.assertEquals(0f, (noBits >>> 9) * 0x1.0p-23f, 0); | ||
| Assert.assertEquals(0f, (noBits >>> 8) * 0x1.0p-24f, 0); | ||
| Assert.assertEquals(0f, Float.intBitsToFloat(0x7f << 23 | noBits >>> 9) - 1.0f, 0); |
There was a problem hiding this comment.
Suggested change
| Assert.assertEquals(0f, Float.intBitsToFloat(0x7f << 23 | noBits >>> 9) - 1.0f, 0); | |
| Assert.assertEquals(0.0f, Float.intBitsToFloat(0x7f << 23 | noBits >>> 9) - 1.0f, 0); |
There was a problem hiding this comment.
Fixed all 0f with 0.0f. Thanks.
This changes the nextFloat/nextDouble methods to use an extra bit of state from the underlying int or long primitive.
aherbert
force-pushed
the
improvement-RNG-81
branch
from
72aa242
to
647326a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the nextFloat/nextDouble methods to use an extra bit of
state from the underlying int or long primitive.