Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEXT-67: use [lang]'s Range to replace if/else logic #41

Merged
merged 1 commit into from Jun 12, 2017

Conversation

kinow
Copy link
Member

@kinow kinow commented May 22, 2017

Simplify logic by using Apache Commons Lang's Range class. The if in the translate method is not very intuitive.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 96.649% when pulling 9493dfb on kinow:TEXT-67 into 343b4a9 on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 96.649% when pulling 9493dfb on kinow:TEXT-67 into 343b4a9 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 96.649% when pulling 9493dfb on kinow:TEXT-67 into 343b4a9 on apache:master.

@ameyjadiye
Copy link
Contributor

Though its very negligible -0.004%, I wonder why code coverage is decreased ?

@kinow
Copy link
Member Author

kinow commented May 23, 2017

I wonder if perhaps due to the fact that it removes code & if/else branches.

@PascalSchumacher
Copy link
Contributor

Let's merge this!

@asfgit asfgit merged commit 9493dfb into apache:master Jun 12, 2017
asfgit pushed a commit that referenced this pull request Jun 12, 2017
@kinow kinow deleted the TEXT-67 branch April 9, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants