Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEXT-93: RandomStringGenerator accepts a list of valid characters #54

Merged
merged 7 commits into from Jun 29, 2017
Merged

TEXT-93: RandomStringGenerator accepts a list of valid characters #54

merged 7 commits into from Jun 29, 2017

Conversation

ameyjadiye
Copy link
Contributor

Added selectFrom feature :

selectFromList(char[] chars)
selectFromList(List<Character> charList)

@coveralls
Copy link

coveralls commented Jun 22, 2017 •
edited

Coverage Status

Coverage decreased (-0.02%) to 97.306% when pulling 2dfadf4 on ameyjadiye:TEXT-93 into 569dbc0 on apache:master.

@coveralls
Copy link

coveralls commented Jun 23, 2017 •
edited

Coverage Status

Coverage decreased (-0.02%) to 97.308% when pulling f9177e2 on ameyjadiye:TEXT-93 into 569dbc0 on apache:master.

@coveralls
Copy link

coveralls commented Jun 23, 2017 •
edited

Coverage Status

Coverage decreased (-0.02%) to 97.305% when pulling df30bf9 on ameyjadiye:TEXT-93 into 569dbc0 on apache:master.

kinow
kinow approved these changes Jun 24, 2017
View reviewed changes
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues in formatting (javadocs, and also normally @return and @param have no period. Site builds OK and reports look good, including CheckStyle, so I guess that's not an issue. Coverage doesn't seem like an issue. Other than that, +1.

src/main/java/org/apache/commons/text/RandomStringGenerator.java Outdated
* filters for code points
* @param random
* source of randomness
* filters for code points
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation got a bit messed up here, and the param entry for minimumCodePoint too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, seems like IntelliJ did this unknowingly, fixed it!

@coveralls
Copy link

coveralls commented Jun 24, 2017 •
edited

Coverage Status

Coverage decreased (-0.02%) to 97.305% when pulling 9db7708 on ameyjadiye:TEXT-93 into 569dbc0 on apache:master.

@ameyjadiye
Copy link
Contributor Author

As per discussion hereTEXT-93 we are good to merge this PR.

@asfgit asfgit merged commit 9db7708 into apache:master Jun 29, 2017
@ameyjadiye ameyjadiye deleted the TEXT-93 branch June 29, 2017 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinow kinow kinow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ameyjadiye @coveralls @kinow @asfgit