Fixed TEXT-234 #546
Closed
Fixed TEXT-234 #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @TobiasKiecker |
|
Looks fine to me, but you just updated StrBuilder (the deprecated class) while TextStringBuilder, which in this aspect is a direct copy, remains unchanged |
Feel free to provide a PR with changes in the same style for other classes 😉 |
|
I will do that |
TobiasKiecker
added a commit
to TobiasKiecker/commons-text
that referenced
this pull request
May 23, 2024
continued to implement changes to Javadoc as mentioned in: apache#546
garydgregory
pushed a commit
that referenced
this pull request
May 25, 2024
continued to implement changes to Javadoc as mentioned in: #546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed documentation for setNewLineText, getNewLineText and appendNewLine in both StrBuilder and TextStringBuilder to better reflect their behavior