Upgrade to JUnit 5.1

[PascalSchumacher]

No description provided.

[coveralls]

Coverage remained the same at 97.83% when pulling 91a9956 on PascalSchumacher:junit_5 into 6f06de9 on apache:master.

[garydgregory]

Hi Pascal! Thank you for the PR. My only hesitation with JUnit 5 is that it does not work in Eclipse yet, for me at least.

[PascalSchumacher]

The only problem I encountered was that I had to delete the existing JUnit run configurations for commons-text (I'm using Eclipse Oxygen.3 and it does not seem to be able to update a run configuration from JUnit 4 to JUnit 5).

[PascalSchumacher]

JUnit 5 should work with any Eclipse Version released during the last year (as long as you delete existing run configurations for the project).

@garydgregory Can you give running this a try? I would like to merge it. Thanks!

[kinow]

Tested the master branch first, and everything obviously worked. Then switched to this branch, and got an error message, then Eclipse opened the run configuration.

Followed @PascalSchumacher 's suggestion, removed the project JUnit run configurations, then re-run the class, and everything worked with no issues.

Tested a class, a method, and the entire project, by right clicking each of these, then Run As -> JUnit Test (i.e. Eclipse also recognized the files as JUnit tests).

Also put a breakpoint in some random method, then Debug As -> JUnit Test, and it worked as expected too.

Looks good to me. Might be a good idea to wait for @garydgregory 's feedback as I have very little experience with JUnit 5 for now, besides reading slides/docs/etc.

[kinow]

Screenshot with Eclipse version, and sample output (looks exactly like the output with JUnit 4).

[garydgregory]

Comitted! :-) Works for me as well in Eclipse 4.7.3. Thanks you @PascalSchumacher .

[PascalSchumacher]

Great!

@kinow Thanks in-depth check!