Add Getters for IBANValidator's RegexValidator its patterns #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the validator field is package-protected so you could get access from the relevant package (as is done by the test class). |
sebbASF
reviewed
Jul 31, 2020
| * @return the array of <code>patterns</code> used to validate values. | ||
| */ | ||
| public Pattern[] getPatterns() { | ||
| return patterns; |
There was a problem hiding this comment.
The method must return a copy of the the patterns otherwise the caller can mutate the array.
|
@arnaudfnr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
For a project I need to have access to the regex used to validate IBANs, therefore I added a couple of getters to make it possible.
@sebbASF I saw that you have been contributing quite a lot recently, have you planned to perform a release ? If yes, do you have an estimation of its date please ? It would be nice if these changes could be added 🙏