Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new countries to IBAN list: DJ, RU #88

Merged
merged 7 commits into from
Jan 16, 2023

Conversation

tatiana-scda
Copy link
Contributor

@tatiana-scda tatiana-scda commented Oct 7, 2022

The list has been updated in 2022.
Reference: https://www.iso13616.org/

Under the file iban-registery, we can see the following missing countries and their IBANs, added into the tests:

image

image

image

image

@garydgregory
Copy link
Member

@tatiana-scda
You must have not run the tests as this PR fails the build. Run mvn before pushing a PR please.

@tatiana-scda
Copy link
Contributor Author

@garydgregory Locally validated, should be okay now

@tatiana-scda
Copy link
Contributor Author

hey @garydgregory can we retry the workflows?

@garydgregory
Copy link
Member

@tatiana-scda
Rebase on master and push.

@tatiana-scda
Copy link
Contributor Author

@garydgregory already up to date 👍🏿

@garydgregory
Copy link
Member

Hi @tatiana-scda
Please rebase on git master and check what might still be missing. TY!

@garydgregory garydgregory changed the title Adding new contries to IBAN list Adding new countries to IBAN list Jan 16, 2023
@garydgregory
Copy link
Member

@tatiana-scda
FYI, I resolved the conflict.

@garydgregory garydgregory merged commit 31afb45 into apache:master Jan 16, 2023
@garydgregory garydgregory changed the title Adding new countries to IBAN list Adding new countries to IBAN list: DJ, RU Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants