Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VFS-810: Use different UriBuilder for Http4FileSystem #222

Closed
wants to merge 2 commits into from

Conversation

JanAelb
Copy link

@JanAelb JanAelb commented Nov 25, 2021

There is an issue when parsing urls containing backslashes in Http4FileSystem and derived classes.

https://issues.apache.org/jira/browse/VFS-810

@garydgregory
Copy link
Member

-1 as the string in the example "http4://alice\\1234:secret@localhost:80" is not an RFC compliant URI, neither in RFC 2396 or RFC 3986.

The problem is two-fold though, the above, plus the fact that there is a long-standing issue within VFS where we incorrectly handle percent-encoded values.

If in the above you meant to escape the a single \ character then then URL should be "http4://alice%5C1234:secret@localhost:80"; but, that seems to cause problems within VFS, so that's what needs to be fixed.

@JanAelb
Copy link
Author

JanAelb commented Nov 25, 2021

Thank you for the quick response.
Passing "http4://alice%5C1234:secret@localhost:80" is indeed the problem I want to handle. I updated the tests.

@garydgregory
Copy link
Member

I have a possible fix in the guts of VFS, stay tuned... This PR is still not the best path IMO because it only deals with a single provider, does not solve the general problem, and adds a dependency on yet another library which happens to be used to test Hadoop.

@JanAelb
Copy link
Author

JanAelb commented Nov 26, 2021

Thank you 👍

@JanAelb JanAelb closed this Nov 26, 2021
@JanAelb JanAelb deleted the VFS-810-UriBuilder branch November 26, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants