[VFS-683] Class loader thread safety #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ivakegg
commented
Jan 13, 2023
ivakegg
commented
- To ensure that the closing of files does not interfere with
- reading the content, the FileObjectUtils read methods must
- be synchronized on the underlying filesystem just like the
- close AbstractFileObject close and detach methods.
- Added a test case that demostrated the issue.
ivakegg
force-pushed
the
master
branch
2 times, most recently
from
7a3bed6
to
185c16c
Compare
commons-vfs2/src/main/java/org/apache/commons/vfs2/util/FileObjectUtils.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/main/java/org/apache/commons/vfs2/util/FileObjectUtils.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/main/java/org/apache/commons/vfs2/util/FileObjectUtils.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/main/java/org/apache/commons/vfs2/util/FileObjectUtils.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java
Outdated
Show resolved
Hide resolved
commons-vfs2/src/test/java/org/apache/commons/vfs2/impl/VfsClassLoaderTests.java
Outdated
Show resolved
Hide resolved
garydgregory
requested changes
Jan 13, 2023
|
I will try to track down the fails in the macos vms. I will have to instrument the test case to see what is going on. |
|
Well, everything appears to have passed this time. I will up the number of threads in the test to see if I can force the failures again. |
* To ensure that the closing of files does not interfere with * reading the content, the FileObjectUtils read methods must * be synchronized on the underlying filesystem just like the * close AbstractFileObject close and detach methods. * Added a test case that demostrated the issue.
clear that out, possibly which the getHeadMethod is being called.
|
This is ready for a final review. I can squash the commits into one when you are ready. |
garydgregory
changed the title
asfgit
pushed a commit
that referenced
this pull request
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.