[VFS-497] Ported filters from Commons IO #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-schnell
changed the title
|
@ecki @garydgregory Any opinion on this? |
|
I do not like it. Commons CVS is already a kitchen sink of sorts, so would just centralize all filters in Commons IO and make VFS depend on IO. |
|
Darn autocomplete! I meant VFS, not CSV. |
|
I checked this option before I decided to port the code to VFS. Unfortunately commons IO filter uses the Java type File all over the place. You would need to make an incompatible change to the commons io code or create a new package for it. So, I'd suggest just to merge the (three years old) code. |
|
It's a bit heavyweight and I had no need for those filters however I like the fact that the patch does not add a dependency, so it is fine with me. Will merge it. |
|
Great. Go ahead! |
asfgit
pushed a commit
that referenced
this pull request
Mar 31, 2019
Patch from Michael Schnell adapted to different folder names. Also clean ups like removing extra generics in object creation not needed since Java 7.
|
Merged with some changes. |
asfgit
pushed a commit
that referenced
this pull request
Apr 1, 2019
Add @SInCE 2.4 and convert IOCase from class to enum. Use try-with-resources.
asfgit
pushed a commit
that referenced
this pull request
Apr 1, 2019
Add CanExecuteFileFilter. Better test method name. Use try-with-resources. Longer formatted lines.
asfgit
pushed a commit
that referenced
this pull request
Apr 19, 2019
The method org.apache.commons.vfs2.FileFilter.accept(FileSelectInfo) now throws a FileSystemException. This change is binary compatible but is not source compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/VFS-497