Skip to content
Permalink
Browse files
cleanup!: remove deprecated settings & add todo comments (#1274)
* chore: add todo task for setSaveFormData
* cleanup!: remove deprecated setSavePassword
* cleanup!: remove deprecated setDatabasePath
* chore: add todo task for setGeolocationDatabasePath
  • Loading branch information
erisu committed Jul 14, 2021
1 parent 7da531c commit adc380cf9fcf20987a9664020eed1214bedf0733
Showing 1 changed file with 3 additions and 4 deletions.
@@ -155,9 +155,9 @@ private void initWebViewSettings() {
String manufacturer = android.os.Build.MANUFACTURER;
LOG.d(TAG, "CordovaWebView is running on device made by: " + manufacturer);

//We don't save any form data in the application
// We don't save any form data in the application
// @todo remove when Cordova drop API level 26 support
settings.setSaveFormData(false);
settings.setSavePassword(false);

if (preferences.getBoolean("AndroidInsecureFileModeEnabled", false)) {
//These settings are deprecated and loading content via file:// URLs is generally discouraged,
@@ -173,15 +173,14 @@ private void initWebViewSettings() {
// We keep this disabled because we use or shim to get around DOM_EXCEPTION_ERROR_16
String databasePath = webView.getContext().getApplicationContext().getDir("database", Context.MODE_PRIVATE).getPath();
settings.setDatabaseEnabled(true);
settings.setDatabasePath(databasePath);


//Determine whether we're in debug or release mode, and turn on Debugging!
ApplicationInfo appInfo = webView.getContext().getApplicationContext().getApplicationInfo();
if ((appInfo.flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0) {
enableRemoteDebugging();
}

// @todo remove when Cordova drop API level 24 support
settings.setGeolocationDatabasePath(databasePath);

// Enable DOM storage

0 comments on commit adc380c

Please sign in to comment.