Skip to content

Commit

Permalink
fix(prepare): delete splash screens if none are used
Browse files Browse the repository at this point in the history
Fixes #1226
  • Loading branch information
raphinesse committed May 4, 2021
1 parent f9e8ce8 commit fa37f1a
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions bin/templates/cordova/lib/prepare.js
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,13 @@ function makeSplashCleanupMap (projectRoot, resourcesDir) {
function updateSplashes (cordovaProject, platformResourcesDir) {
var resources = cordovaProject.projectConfig.getSplashScreens('android');

// if there are "splash" elements in config.xml
// if there are no "splash" elements in config.xml
if (resources.length === 0) {
events.emit('verbose', 'This app does not have splash screens defined');
return;
// We must not return here!
// If the user defines no splash screens, the cleanup map will cause any
// existing splash screen images (e.g. the defaults that we copy into a
// new app) to be removed the app folder, which is what we want.
}

// Build an initial resource map that deletes all existing splash screens
Expand Down

0 comments on commit fa37f1a

Please sign in to comment.