Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong name in configuration for platform add android #1210

Closed
3 tasks done
ath0mas opened this issue Apr 16, 2021 · 0 comments · Fixed by #1213
Closed
3 tasks done

Wrong name in configuration for platform add android #1210

ath0mas opened this issue Apr 16, 2021 · 0 comments · Fixed by #1213

Comments

@ath0mas
Copy link
Contributor

ath0mas commented Apr 16, 2021

Bug Report

Problem

What is expected to happen?

Config name for cordova platform add android must be same as the value first set during create, even with spaces and accents, and same as for ios platform.
Given this value is correctly set in config.xml and other places for the created cordova project.

What does actually happen?

Name is not correct: spaces and accents are replaced with _ (for example visible in the .idea/.name file since #1173).

Information

Command or Code

cordova create hello com.example.hello "Hello World accentué"
cd hello/

but cordova platform add android gives wrong name:

Using cordova-fetch for cordova-android@^9.0.0
Adding android project...
Creating Cordova project for the Android platform:
        Path: platforms\android
        Package: com.example.hello
        Name: Hello_World_accentu_
..
Android project created with cordova-android@9.1.0

while cordova platform add ios gives correct config name:

Using cordova-fetch for cordova-ios@^6.1.0
Adding ios project...
Creating Cordova project for the iOS platform:
        Path: platforms\ios
        Package: com.example.hello
        Name: Hello World accentué
iOS project created with cordova-ios@6.2.0

Environment, Platform, Device

Version information

Cordova CLI 10.0.0
Cordova Android 9.1.0
Windows 10

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
ath0mas added a commit to ath0mas/cordova-android that referenced this issue Apr 17, 2021
…ache#1210

no known limitation with non-word characters, accents, unicode or spaces
ath0mas added a commit to ath0mas/cordova-android that referenced this issue Jul 31, 2021
…ache#1210

no known limitation with non-word characters, accents, unicode or spaces
ath0mas added a commit to ath0mas/cordova-android that referenced this issue Aug 2, 2021
…ache#1210

no known limitation with non-word characters, accents, unicode or spaces
ath0mas added a commit to ath0mas/cordova-android that referenced this issue Aug 2, 2021
…ache#1210

no known limitation with non-word characters, accents, unicode or spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant