I have a question about development with android stuido 3.2 and higher

[nrikiji]

When opening the platform / android project created after executing the following command with android studio 3.2 or later, the following error occurs and it can not be built.

Does this have problems with my environment? Or is it that it does not correspond to android stuido 3.2 or higher with correct behavior?

create android project

$ cordova create test com.example.test Test && cd $_
$ cordova platform add android@7.1.1

error

ERROR: The minSdk version should not be declared in the android manifest file. You can move the version from the manifest to the defaultConfig in the build.gradle file.
Move minSdkVersion to build files and sync project
Affected Modules: CordovaLib, app

WARNING: The targetSdk version should not be declared in the android manifest file. You can move the version from the manifest to the defaultConfig in the build.gradle file.
Move targetSdkVersion to build file and sync project
Affected Modules: app

environment

npm 6.4.1
node v10.15.0
cordova 8.1.2

[brodybits]

I spotted similar error messages with android@nightly (8.0.0-dev) on Android Studio 3.3. Android Studio 3.3 offered me an option to fix the project automatically.

If I would accept the option to fix the project, Android Studio 3.3 would automatically update the following files to define minSdk and targetSdk values in Gradle instead of AndroidManifest.xml:

• platforms/android/CordovaLib/AndroidManifest.xml
• platforms/android/CordovaLib/build.gradle
• platforms/android/app/build.gradle
• platforms/android/app/src/main/AndroidManifest.xml

I think a similar kind of a solution would be needed to resolve the issue discussed in #508 (inconsistent handling of min/target SDK values), but may need some rework to respect the Gradle properties documented in https://cordova.apache.org/docs/en/latest/guide/platforms/android/#setting-gradle-properties.

Marked as a bug, hope we can resolve it before the major release for Cordova 9 (apache/cordova#10).

[nrikiji]

I spotted similar error messages with android@nightly (8.0.0-dev) on Android Studio 3.3. Android Studio 3.3 offered me an option to fix the project automatically.

Thank you very much. Would you please tell me where this option can be set

[JacobSiegle]

In android studio let the gradle build run and fail. In the error log it will have a message about auto fixing/refactoring the issue. Click the message then hit refactor in the bottom left.

[janpio]

Is this really fixed by this PR merge @brodybits?

[brodybits]

Is this really fixed by this PR merge @brodybits?

Should be

[brodybits]

I would like to reopen this issue until we get a chance to actually test it and ensure the resulting issue #666 is resolved.

[BorntraegerMarc]

@brodybits I specify the min SDK version like so:

<platform name="android">
        <preference name="android-minSdkVersion" value="21" />
</platform>

Does your PR also respect this preference? And if yes: Do you when your enhancement is released? Using cordova-android v8 atm

[brodybits]

This should be resolved in cordova-android@8.0.0. If not then please provide https://stackoverflow.com/help/mcve demo of the issue.

[BorntraegerMarc]

@brodybits I just created a brand new cordova app like described here: https://cordova.apache.org/docs/en/latest/guide/cli/index.html

Configured the android platform to v8.0.0

Ran cordova platform add android and cordova build android. When opening the project with android studio I get this notification:

So I click "update" and then I get this error:

The app still runs and it works when I click then on "move" in android studio. But it would be nice not to need to do that

[nprather]

This should be resolved in cordova-android@8.0.0. If not then please provide https://stackoverflow.com/help/mcve demo of the issue.

I'm running android 8.0 and received this same error about the minsdk location and did the Refactor to fix option too...

[piotr-cz]

Fix by @brodybits brodybits has been reverted in #666 before cordova-android 8.0 has been released.
Seems that it didn't work correctly in one specific scenario

[erisu]

This should have be resolved with PR #699 and is now merged into master. It will be available in the next release.

[BorntraegerMarc]

Thanks for the update @erisu

Do you know when the next release will happen?

[mcastets]

8.1.0 is out today! I can confirm this issue is now fixed! Awesome work guys!

[tryhardest]

so it's like cat-and-mouse. If you upgrade to 8.1.0 you get Can't install plugin: Cannot read property '0' of undefined #581

So you upgrade Branch to 4.0.0. Then another error (check "Branch.h missing") on iOS when on 4.0.0.

[breautek]

so it's like cat-and-mouse. If you upgrade to 8.1.0 you get Can't install plugin: Cannot read property '0' of undefined #581

So you upgrade Branch to 4.0.0. Then another error (check "Branch.h missing") on iOS when on 4.0.0.

Sounds like a plugin problem, not a cordova-android problem.

[tryhardest]

@breautek accurate. 🙏