-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new Android App Bundle package format #729
Comments
For reference: Previous question issue about support of bundles: #610 |
I'm able to generate both 32-bit and 64-bit versions using As Android App Bundle package is not supported by cordova-android yet, should I upload both By uploading both the apk files, I'll end up creating one more project for the 64-bit version and also with different version code as mentioned by android here https://developer.android.com/google/play/publishing/multiple-apks |
Because crosswalk uses native libraries, yes you will have to build a 32bit and a 64bit version of the APK and upload them both to the google play store. This is what I do for my apps currently since I haven't moved away from crosswalk yet. |
@breautek Thanks for the comment. |
Both APKs needs to have the same package ID. So they get uploaded to the same project. When you enable multiple APKs, the build will add a digit to your versionCode to represent 32bit/64bit. Google play store will automatically select the proper APK for the device that is installing the app. To prevent hijacking this thread, if you have anymore questions about multiple APKs you should open up a new issue. |
Hi, The steps are:
Note: if you have problem whith minSDK version, fix this and make a resync |
Whilst the Android Studio work around is great, I would like to integrate this with our CI Server and therefore interested to understand when the Cordova CLI can build with this output instead of APK. |
We are always open for PRs from the community! You will have to understand how the current Android build works, then see if there is an equivalent for the commands for App Bundles (vs. APKs) and then adapt these back into Cordova Android. (https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/build, https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/Api.js#L253-L314 and https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/build.js will probably be your starting point, on to https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/builders/ProjectBuilder.js which seems to do the actual building - if you have any questions or need help, feel free to ping me here or on slack.cordova.io) |
What android-cordova version did you use to do that? Didn't you have a problem with the android-gradle plugin version? |
We are facing the same problem right now. Just as @JonSmart wrote above, a solution to integrate this with CI Servers is required in our scenario, as we are working with a great number of apps in an automated process. Please prioritize, if at all possible. |
@anh1979 As I wrote before we are happy to review any Pull Requests done by the community. |
These warnings do not block the submission of the app. They are only warnings of recommendations. Check other pending items in the left side menu. Play Console is not very intuitive. @fabiodiniz na verdade esses avisos são somente avisos, eles não estão impedindo você de lançar para produção. Você consegue enviar para produção subindo os .apk's como sempre. Veja os itens do menu esquerdo, todos devem estar "checkados" (verdes). O que acontece é que você deve ter itens pendentes de revisão nesse menu. |
@GuilhermeLessa vc tem razão amigo, confusão minha aqui, valeu 🙏
Yeah, u're right. My mistake 😳 |
Any way of doing it only with command line using |
@jfoclpf I got it working on circle ci. The steps are:
4 - Upload app.aab to google play. |
Thanks, @viktor-shmigol, I was able to generate an |
The aab file size is not the served file size. Google Play store will tell you what will be the approximate served file sizes for each device configuration when you upload the aab file. |
Speaking realistically, you’re not going to see much (any?) size savings for Cordova apps because the majority of the size is the web content assets and Google can’t strip any of that out. |
@breautek |
@krunal9421 Please open a new issue or better Stack Overflow question about this and don't derail this issue. Thanks. |
Hello. The instructions above are right on the money. Cheers! |
Thanks so much, working perfectly. |
@dpogue That's true for a very simple Cordova app, but if you start including plugins with native SDKs that contain architecture-specific compiled C libraries, then the app bundle starts to pay off since it only distributes the library variants specific to the device architecture rather than the library variant for every architecture (as a multi-arch APK does). |
This sounds awesome! But didn't work for me. When I run the `
FAILURE: Build failed with an exception.
BUILD FAILED in 7s |
Running the normal build command once should install gradlew for you. |
Awesome! With your help I got it. Thank you all. To generate gradlew I executed the command
This generated to me a folder with gradlew.bat. After I executed the command |
Oh my God! I went the long way. Thank you! |
Doesn't hurt to know what goes on behind the scenes ;) |
This comment has been minimized.
This comment has been minimized.
cordova-android@8.1.0 has not been released, it has been tagged to begin the release voting process. It will be published to npm when it has been released. |
My bad, I edited my comment to avoid confusion. |
Thank you, but i could generate my app with android studio, it was hard but
actualy it works. But thanks for helping me
No dia quinta-feira, 12 de setembro de 2019, Norman Breau <
notifications@github.com> escreveu:
… Also, ***@***.*** has been released, which includes bundle
support. With 8.1.0 installed, you can use cordova build android
--release -- --packageType=bundle to build bundles. (note the double set
of -- -- hyphens)
***@***.*** has *not* been released, it has been tagged to
begin the release voting process. It will be published to npm when it has
been released.
My bad, I edited my comment to avoid confusion.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#729?email_source=notifications&email_token=AMN5L6PMPOQOY32C7YR5KPTQJJPUZA5CNFSM4HLQ5F7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6SKYIY#issuecomment-530885667>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMN5L6I66QY6QW34O5D2GLTQJJPUZANCNFSM4HLQ5F7A>
.
|
To help more people I made a short series of videos on YouTube. In these three videos I show you how you can build your app. Check out https://www.youtube.com/playlist?list=PLfeu5i2CGb0uJeI8NshaN1TLXy1eJg2No I hope this can help. |
Ho thanks.. Can you make a video talking about cordova firebase plugin, to
show notifications on ionic 4 applications using android platform.. These
error are killing me
A sábado, 14/09/2019, 08:57, Edigleysson Silva <notifications@github.com>
escreveu:
… To help more people I made a short series of videos on YouTube. In these
three videos I show you how you can build your app.
Chekc out
https://www.youtube.com/playlist?list=PLfeu5i2CGb0uJeI8NshaN1TLXy1eJg2No
I hope this can help.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#729?email_source=notifications&email_token=AMN5L6OIYEHSSBJGECAOBM3QJSDNRA5CNFSM4HLQ5F7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WV7CI#issuecomment-531455881>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMN5L6KGAEQJG3JCACTXZ7LQJSDNRANCNFSM4HLQ5F7A>
.
|
Ho, não sabia que falavas português... Então estou a ter problemas com
notificações em ionic 4 por causa do problema no plugin de firebase que deu
em abril.. Podes me ajudar?
A domingo, 15/09/2019, 08:10, Clint Lucas <clintlucasfernando@gmail.com>
escreveu:
… Ho thanks.. Can you make a video talking about cordova firebase plugin, to
show notifications on ionic 4 applications using android platform.. These
error are killing me
A sábado, 14/09/2019, 08:57, Edigleysson Silva ***@***.***>
escreveu:
> To help more people I made a short series of videos on YouTube. In these
> three videos I show you how you can build your app.
>
> Chekc out
>
> https://www.youtube.com/playlist?list=PLfeu5i2CGb0uJeI8NshaN1TLXy1eJg2No
>
> I hope this can help.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#729?email_source=notifications&email_token=AMN5L6OIYEHSSBJGECAOBM3QJSDNRA5CNFSM4HLQ5F7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WV7CI#issuecomment-531455881>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AMN5L6KGAEQJG3JCACTXZ7LQJSDNRANCNFSM4HLQ5F7A>
> .
>
|
Sim. Podemos chegar a solução. O que está havendo? |
parece que o cordova firibase plugin teve um erro. podes acompanhar melhor
nesse link arnesson/cordova-plugin-firebase#1057
This is due to the firebase updates on April 05. Here
https://firebase.google.com/support/release-notes/android#update_-_april_02_2019,
I found the last working versions and adjusted my project.properties
accordingly
like so
mas nao funciona na mesma
Edigleysson Silva <notifications@github.com> escreveu no dia domingo,
15/09/2019 à(s) 13:29:
… Sim. Podemos chegar a solução. O que está havendo?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#729?email_source=notifications&email_token=AMN5L6KEG6V2PQH3O5SUY6LQJYMBPA5CNFSM4HLQ5F7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XO2TQ#issuecomment-531557710>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMN5L6OMYLOG7DOXVUDP7X3QJYMBPANCNFSM4HLQ5F7A>
.
|
Guys, these seems a) off topic and b) please stick to English |
ok tim
Tim Brust <notifications@github.com> escreveu no dia segunda, 16/09/2019
à(s) 01:11:
… Guys, these seems a) off topic b) please stick to English
You might want to continue this chat on a more suitable platform than a
closed GitHub issue :)
Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#729?email_source=notifications&email_token=AMN5L6I64NVVLJ6TWZUWFETQJ26LHA5CNFSM4HLQ5F7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6X27GQ#issuecomment-531607450>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMN5L6LJ2I5PECUBFU2QC2TQJ26LHANCNFSM4HLQ5F7A>
.
|
@fabiodiniz, i got same problem with you about that warning sign..may know what mistake did u noticed until u can publish without using android app bundle? |
Google does not prevent you from publishing APKs. I still do this in my personal projects. Google however, does require you to supply an APK that contains the 64bit architecture of native libraries, if you're app includes native libraries. You can either do this by including all architectures you support in a single APK or by using a multi-apk setup where each APK is for a specific architecture. Google encourages you to include all shared library architectures in a form of a bundle. This would be best deployment strategy moving forward, but they don't stop you from using an any of the APK deployment strategies. |
I tried with 8.1.0:
But I get an error:
What could be the reason? |
@desmeit cordova cannot find your android sdk directory, so you might have a misconfiguration somewhere. Please open a new issue and fill out the form appropriately as it will tell us everything we will need to know to further help you. You may even find the problem yourself in the process. Thanks. |
after update to cordova-android 8.0.0 But I get an error
|
This is exactly what I needed. Worked like a charm on github actions (with some minnor modifications) |
It would be nice if we could get this documented somewhere. |
Shouldn't be necessary to go into From what I can see looking at the history of this discussion, looks like most users were either using frameworks that doesn't allow you to pass down this flag, or they were using a version pre 8.1.0, which is the version that introduced bundle support (hence the need to use gradle manually for those users) |
Feature Request
Motivation Behind Feature
Google recommends using the new Android App Bundle format for apps uploaded to Google Play. When you upload an APK a warning is displayed which encourages to use the newer format.
Feature Description
Google provides information on the new package format on:
https://developer.android.com/platform/technology/app-bundle
It would be great if Cordova would support this new package format out of the box or with a parameter for the build command.
The text was updated successfully, but these errors were encountered: