Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add WebViewAssetloader to default allow list #1275

Merged
merged 2 commits into from Jul 14, 2021

Conversation

NiklasMerz
Copy link
Member

@NiklasMerz NiklasMerz commented Jul 14, 2021

Platforms affected

Android

Motivation and Context

Addresses issues in #1217

Closes #1217

Description

With the introduction of the WebViewAssetloader #1137 and the Allow List Plugin #1138 we need to add the origin / href the app is running to the allowlist.

Testing

Create a blank new app with one plugin

cordova create test
cd test
cordova platform add https://github.com/apache/cordova-android#webviewassetloader-allowlist
cordova plugin add cordova-plugin-file
cordova run android

These steps will produce the hello world cordova app that should show "deviceready" with this pr. See issue.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@NiklasMerz NiklasMerz added this to the 10.0.0 milestone Jul 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #1275 (7f5fbad) into master (3e870e3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1275   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files          21       21           
  Lines        1646     1646           
=======================================
  Hits         1206     1206           
  Misses        440      440           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e870e3...7f5fbad. Read the comment docs.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit bedb442 into master Jul 14, 2021
@erisu erisu deleted the webviewassetloader-allowlist branch July 14, 2021 13:29
sakibguy added a commit to sakibguy/cordova-android that referenced this pull request Jul 15, 2021
fix: add WebViewAssetloader to default allow list (apache#1275)
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application does not initialize correctly on 10.x nightly/dev master
3 participants