Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GH-1616): Fix monochrome checks #1632

Merged

Conversation

breautek
Copy link
Contributor

Platforms affected

Android

Motivation and Context

fixes #1616

Description

cordova-android 12 introduces support for monochrome icons. It was intended for it to be optional.
However due to a faulty check, if you didn't supply the monochrome property, adaptive icons will not be written out.

I've corrected the check. Additionally I added the dedent package which is a string template formatter so that
we can more easily format some of our inline templates to make it easier to read.

I've also added a warning for when the monochrome property is given without the required adaptive properties. Tests were added to assert that icons are written as expected with and without the monochrome property as well as the warning is emitted.

There is one caveat, the warning in practice isn't seen by the user because the CLI ends up kicking out earlier via

https://github.com/apache/cordova-android/blob/master/lib/prepare.js#L666

But I opted to keep it anyway.

Testing

Ran npm test.
Packed and tested locally and observed adaptive icons being written as expected with and without monochrome icon.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek added this to the 12.0.1 milestone Jul 13, 2023
@breautek breautek merged commit c9e7c59 into apache:master Jul 13, 2023
9 checks passed
@breautek breautek deleted the fix/adaptive-monochrome-requirements branch July 13, 2023 16:18
usernuno pushed a commit to OutSystems/cordova-android that referenced this pull request Jul 26, 2023
breautek added a commit to breautek/cordova-android that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adaptive Icon not working with cordova-android 12
2 participants