Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-9382 [Android] Fix KeepRunning setting when Plugin activity is showed #200

Closed
wants to merge 1 commit into from
Closed

CB-9382 [Android] Fix KeepRunning setting when Plugin activity is showed #200

wants to merge 1 commit into from

Conversation

sgrebnov
Copy link
Member

@vladimir-kotikov
Copy link
Member

LGTM

@asfgit asfgit closed this in 32b7275 Jul 20, 2015
@omefire
Copy link
Contributor

omefire commented Jul 20, 2015

Why don't we set keepRunning to true here ?
We seem to want to set keepRunning to false while still allowing things to run in the background under certain conditions, which seems against to be what the goal of the flag is.
I'm wondering what's preventing us from just setting keepRunning to true.

@vladimir-kotikov vladimir-kotikov deleted the CB-9382 branch July 23, 2015 07:19
infil00p pushed a commit to infil00p/cordova-android that referenced this pull request Aug 28, 2015
@sgrebnov @infil00p
CB-9382 [Android] Fix KeepRunning setting when Plugin activity is sho…
e124669 
…wed. This closes apache#200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgrebnov @vladimir-kotikov @omefire