Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12835: add a Context getter in CordovaInterface #385

Merged
merged 1 commit into from Nov 28, 2017
Merged

CB-12835: add a Context getter in CordovaInterface #385

merged 1 commit into from Nov 28, 2017

Conversation

dreifachstein
Copy link
Contributor

A custom engine may live outside of the Activity's lifecycle and the
Activity instance may not always be available. This getter allows
Context accesses in all cases.

A custom engine may live outside of the Activity's lifecycle and the
Activity instance may not always be available. This getter allows
Context accesses in all cases.
@codecov-io
Copy link

Codecov Report

Merging #385 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   39.52%   39.52%           
=======================================
  Files          16       16           
  Lines        1551     1551           
  Branches      277      277           
=======================================
  Hits          613      613           
  Misses        938      938

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6e898...1790673. Read the comment docs.

@filmaj
Copy link
Contributor

filmaj commented Jun 23, 2017

Does anything need to change in the plugin authoring documentation for Android as a result of this?

https://cordova.apache.org/docs/en/latest/guide/platforms/android/plugin.html

Maybe the Android Integration section needs updating? It references that the context is no longer available?

@infil00p
Copy link
Member

@filmaj Yeah, that definitely needs an update.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm cool with these changes but we absolutely need to update the docs in a separate PR as well.

@infil00p
Copy link
Member

Did anyone ever get around to writing that doc update? Anyone have the link to the PR?

@infil00p
Copy link
Member

Yeah, this isn't that big of a deal to document, I'm going to merge this in now.

@infil00p infil00p merged commit ae823e6 into apache:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants