Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12802: (android) Fix build.gradle to sign when building with multiple APK is enable. #411

Merged
merged 1 commit into from Oct 16, 2017

Conversation

kevin-lot
Copy link
Contributor

@kevin-lot kevin-lot commented Oct 9, 2017

When 'cdvBuildMultipleApks' is true, 'task.name' can have 'validateSigningArmv7Release' or 'validateSigningX86Release' values.

Platforms affected

cordova 7
cordova-android 6.2.3

What does this PR do?

Fix build.gradle to sign when building with multiple APK is enable.

What testing has been done on this change?

Test to build with or without signature and with or without multiple APK.

Checklist

  • Reported an issue in the JIRA database issue on Jira
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

…on is true, 'task.name' can have 'validateSigningArmv7Release' or 'validateSigningX86Release' values too.
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@6fa16b6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #411   +/-   ##
=========================================
  Coverage          ?   42.89%           
=========================================
  Files             ?       17           
  Lines             ?     1688           
  Branches          ?      307           
=========================================
  Hits              ?      724           
  Misses            ?      964           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa16b6...cde238d. Read the comment docs.

@kevin-lot kevin-lot changed the title Include missing values for task.name when 'cdvBuildMultipleApks' opti… CB-12802: (android) Fix build.gradle to sign when building with multiple APK is enable. Oct 9, 2017
@infil00p infil00p merged commit 93efe71 into apache:master Oct 16, 2017
infil00p added a commit to infil00p/cordova-android that referenced this pull request Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants