Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12914: Forgot to bump AndroidManifest.xml for play store reasons #420

Merged
merged 1 commit into from Dec 14, 2017

Conversation

infil00p
Copy link
Member

@infil00p infil00p commented Dec 12, 2017

Platforms affected

Android

What does this PR do?

Bumps the Min API level ( should have been done on 7.0, but we forgot)

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@infil00p infil00p changed the title Forgot to bump AndroidManifest.xml for play store reasons CB-12914: Forgot to bump AndroidManifest.xml for play store reasons Dec 12, 2017
@codecov-io
Copy link

Codecov Report

Merging #420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   43.91%   43.91%           
=======================================
  Files          17       17           
  Lines        1710     1710           
  Branches      317      317           
=======================================
  Hits          751      751           
  Misses        959      959

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d92ca...74e9e21. Read the comment docs.

Copy link
Member

@macdonst macdonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question should we switch the other places in the repo that use earlier min sdk versions?

@infil00p infil00p closed this Dec 14, 2017
@infil00p infil00p reopened this Dec 14, 2017
@infil00p infil00p merged commit d50dedb into apache:master Dec 14, 2017
@infil00p
Copy link
Member Author

infil00p commented Dec 14, 2017

@macdonst Yes. I don't think there should be any though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants