Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13975: (android) Fix to fire pause event when cdvStartInBackground=true #435

Merged
merged 1 commit into from Mar 27, 2018
Merged

Conversation

richturner
Copy link
Contributor

Platforms affected

Android

What does this PR do?

When the app is started with cdvStartInBackground=true then a pendingPause event is cached until the messageChannel is initialised (before the pause event never reached the webview and it wasn't possible to determine in JS code that the app was started in the background), this change results in the following JS events inside the app:

  • pause
  • deviceready

As a user you can then store a flag (e.g. app.inBackground) and this can be checked in 'deviceready' handler.

What testing has been done on this change?

Only manually tested on several Android phones.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

Codecov Report

Merging #435 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #435   +/-   ##
=======================================
  Coverage   43.95%   43.95%           
=======================================
  Files          17       17           
  Lines        1711     1711           
  Branches      318      318           
=======================================
  Hits          752      752           
  Misses        959      959

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6abd6d6...b1551ca. Read the comment docs.

@infil00p
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants