Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14125:(android) Increase old plugin compatibility #449

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

jcesarmobile
Copy link
Member

Platforms affected

Android

What does this PR do?

Increases old plugin compatibility by adding 'app/src/main' to all plugin source-file tags that didn't include it, so the files are copied to the new Android Studio structure

What testing has been done on this change?

Tested with cordova plugin add https://github.com/OutSystems/cordova-plugin-audiorecorder.git as it uses source-file for images and xml

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

Codecov Report

Merging #449 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   44.16%   44.19%   +0.02%     
==========================================
  Files          17       17              
  Lines        1698     1697       -1     
  Branches      314      313       -1     
==========================================
  Hits          750      750              
+ Misses        948      947       -1
Impacted Files Coverage Δ
bin/templates/cordova/lib/pluginHandlers.js 86.7% <ø> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ee925...83e9aef. Read the comment docs.

@brodybits
Copy link
Contributor

Really nice!

Wondering if this should be considered a breaking change or not?

@purplecabbage
Copy link
Contributor

LGTM!
I think this is just a minor.bump as we are not changing apis, just how some missing input is treated.

@jcesarmobile
Copy link
Member Author

Yeah, I don't think it's a breaking change.
If plugins were updated to use the new path, then it won't affect them
If plugins were updated to use resource-file tag instead of source-file tag, then it won't affect them
Plugins with old paths and using source-file tag instead of resource-file tag for resources are currently broken on cordova-android 7.1.0 and this change will make them work as they used to, so shouldn't be breaking change.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should really strongly be encouraging plugins to update to the new project structure, but this makes sense as a move to allow people to update to the latest cordova-android without breaking existing plugins.

@jcesarmobile jcesarmobile merged commit 472ab62 into apache:master Jun 13, 2018
@jcesarmobile jcesarmobile deleted the CB-14125 branch June 13, 2018 21:00
@jcesarmobile
Copy link
Member Author

Agree, but we should start by updating core plugins and docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants