New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit log event instead of logging directly #452

Merged
merged 1 commit into from Jun 16, 2018

Conversation

Projects
None yet
3 participants
@raphinesse
Contributor

raphinesse commented Jun 16, 2018

No description provided.

@codecov-io

This comment has been minimized.

codecov-io commented Jun 16, 2018

Codecov Report

Merging #452 into master will increase coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   44.24%   44.27%   +0.03%     
==========================================
  Files          17       17              
  Lines        1693     1694       +1     
  Branches      311      311              
==========================================
+ Hits          749      750       +1     
  Misses        944      944
Impacted Files Coverage Δ
...in/templates/cordova/lib/builders/GradleBuilder.js 20.75% <50%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 472ab62...671c214. Read the comment docs.

@dpogue

dpogue approved these changes Jun 16, 2018

👍

@raphinesse raphinesse merged commit 2c3db19 into apache:master Jun 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@raphinesse raphinesse deleted the raphinesse:remove-log branch Jun 16, 2018

brodybits added a commit to brodybits/cordova-android that referenced this pull request Jun 21, 2018

brodybits added a commit to brodybits/cordova-android that referenced this pull request Jun 21, 2018

brodybits added a commit to brodybits/cordova-android that referenced this pull request Jul 4, 2018

brodybits added a commit to brodybits/cordova-android that referenced this pull request Jul 10, 2018

brodybits added a commit that referenced this pull request Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment