Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14240 mark 7.1.2-dev on 7.1.x #470

Merged
merged 2 commits into from Aug 2, 2018

Conversation

brodybits
Copy link
Contributor

@brodybits brodybits commented Aug 2, 2018

Platforms affected

Android

What does this PR do?

Mark 7.1.2-dev, using the following command on my improve-patch-and-dev-version-support coho branch (apache/cordova-coho#188):

./cordova-coho/coho prepare-platform-release-branch --version 7.1.2-dev -r android -b 7.1.x --pre 'CB-14240 '

Motivation

Wanted to mark -dev version before cherry-pick from master as proposed in #469

Merge instructions

To be merged by push to 7.1.x branch

What testing has been done on this change?

TODO:

  • check that npm test items pass on Travis CI
  • check that it is possible to do cordova platform add brodybits/cordova-android#cb-14240-mark-7.1.2-dev-on-7.1.x on a new Cordova project and run on Android from command line

Merged without checking these items to unblock other work. Should not break anything.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@brodybits brodybits self-assigned this Aug 2, 2018
@brodybits brodybits merged commit 1efcbfa into apache:7.1.x Aug 2, 2018
@brodybits brodybits deleted the cb-14240-mark-7.1.2-dev-on-7.1.x branch August 2, 2018 17:14
@brodybits
Copy link
Contributor Author

Merged without test or review to unblock other work.

@jcesarmobile
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants