Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes apache/cordova-android#473: Do not attempt an activity for internal url loads #487

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

joeljeske
Copy link

Platforms affected

Android

What does this PR do?

Fixes #473

What testing has been done on this change?

Manual verification that CordovaWebViewImpl.showWebPage given file urls do not initiate an external intent request that crashes the app for Android 7+ devices.

Checklist

…to the webview, return from the internal webview load.
@dpogue
Copy link
Member

dpogue commented Aug 29, 2018

Gonna close and reopen to force a re-run of the unit tests. They were passing on other PRs earlier this week, so hopefully it's just a random failure.

@dpogue dpogue closed this Aug 29, 2018
@dpogue dpogue reopened this Aug 29, 2018
@codecov-io
Copy link

codecov-io commented Aug 29, 2018

Codecov Report

Merging #487 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #487   +/-   ##
======================================
  Coverage    62.9%   62.9%           
======================================
  Files          15      15           
  Lines        1650    1650           
  Branches      308     308           
======================================
  Hits         1038    1038           
  Misses        612     612

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebbd91f...c0188ab. Read the comment docs.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix this and submitting a PR!

@joeljeske
Copy link
Author

@dpogue No problem! Thanks for re-running the tests 👍

@dpogue dpogue merged commit ce53154 into apache:master Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants