Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundled dependencies #493

Merged
merged 3 commits into from Sep 11, 2018

Conversation

3 participants
@raphinesse
Copy link
Contributor

raphinesse commented Sep 11, 2018

Part of apache/cordova#6.

The only dependency version that differed from the bundled one after a normal installation at the time of writing was cordova-common which changed from 2.2.1 to 2.2.5.

@raphinesse raphinesse added this to 🐣 New PR / Untriaged in Apache Cordova: Platform Pull Requests via automation Sep 11, 2018

Apache Cordova: Platform Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Sep 11, 2018

@dpogue

dpogue approved these changes Sep 11, 2018

Copy link
Member

dpogue left a comment

💯👍

@raphinesse raphinesse referenced this pull request Sep 11, 2018

Closed

Remove committed `node_modules` from platforms #6

6 of 6 tasks complete
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 11, 2018

Codecov Report

Merging #493 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   61.64%   61.64%           
=======================================
  Files          16       16           
  Lines        1945     1945           
  Branches      363      363           
=======================================
  Hits         1199     1199           
  Misses        746      746

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b2449...76fe89d. Read the comment docs.

@dpogue dpogue merged commit eadcd33 into apache:master Sep 11, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Apache Cordova: Platform Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Sep 11, 2018

@raphinesse raphinesse deleted the raphinesse:remove-bundled-dependencies branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.