#552: (android) check for build-extras.gradle in the app-parent directory

[DavidWiesner]

Platforms affected

• android

What does this PR do?

• solves issue Cordova project ignores build-extras after toolchain upgrade #552. Therefor include the build-extras.gradle from platforms/android/
• If requested I can change this pull request to check on both places platforms/android/ and platforms/android/app/

What testing has been done on this change?

• in a local build environment

Checklist

• Reported an issue in the JIRA database
• Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
• Added automated test coverage as appropriate for this change.

[janpio]

This would be a breaking change right now, so I guess it would be nicer to just check both locations?

[brodycj]

I think we will need to adapt pluginHandlers.js instead. Followup question is coming on #552.

[brodycj]

I concur with @janpio that we should check both locations.

Alternative is to just update the documentation (apache/cordova-docs#905).

[brodycj]

I just pushed an update to support both locations, didn't test it yet.

[DavidWiesner]

Ok I can update the pull request. Wich file should win in the case both files existing? Should the apply exclusively or in sequence if both files existing?

[codecov-io]

Codecov Report

Merging #553 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #553   +/-   ##
=======================================
  Coverage   61.98%   61.98%           
=======================================
  Files          17       17           
  Lines        1978     1978           
  Branches      369      369           
=======================================
  Hits         1226     1226           
  Misses        752      752

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576ad18...ff1c01b. Read the comment docs.

[brodycj]

Good question. I thought we should run both files, didn't think about the ordering.

I would personally like to see the old location deprecated at some point.

If my commit doesn't help then feel free to remove it with a force push. I am still not a real Gradle expert.

And we should update the documentation as well. If I follow your link and click the edit button it takes me to the following file: https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/guide/platforms/android/index.md

@janpio can you think of anything else?

[DavidWiesner]

I think your commit is just fine. This was my prefered order and method. I hope the old location will stay. It was luck that I found this bug before shipping our alpha build to public. Otherwise ~2000 people local settings and database get lost.

[brodycj]

Thanks @DavidWiesner, would like to get review from one more member before merging.

If someone else does a merge, I recommend a squash merge but please be sure to give @DavidWiesner credit in the commit. I hope we can do this today.