Mark 8.0.0-dev & update cordova.js #558
Conversation
using coho copy-js with the following change from cordova-js-src: * Remove obsolete check for JellyBean to work properly on Android Pie (apacheGH-534)
(Update cordova.js from cordova-js@4.2.4, using coho copy-js)
|
Why is a PR with failing tests being merged? |
It is a build error, no actually failing tests. I deleted my branch right after merge, that is what caused the failure. I didn't see the failure. I tried restoring my branch and restarting the build a couple times. Unfortunately it didn't seem to work. It should go green in the next merge.
I just updated the title. Purpose was only to mark 8.0.0-dev. But the procedure involves regenerating cordova.js, and I wanted to do that in a couple smaller steps, to avoid excessive changes combined in a single commit.
I have some enhancements that help me update cordova.js from a specific cordova-js version. There is quite a bit of review feedback on the PR and I did not a chance to process it. I just updated the description with some more info. Alternative would be to close the WIP PR on cordova-coho and use my own fork, without giving record of what commands I used to do the update. I will admit that this update did not go quite right, not much we can do now. |
Changes
cordova-coho fork used
I use https://github.com/brodybits/cordova-coho/tree/improve-patch-and-dev-version-support in my fork of cordova-coho, with an enhancement to generate cordova.js from a specific version of cordova-js. This lets me keep the generated updates to cordova.js in separate commits instead of all changes combined together in the same commit.
I proposed this update in apache/cordova-coho#188 but did not have a chance to process the review comments. I hope to process the review comments for apache/cordova-coho#188 to be approved for merge in the near future.
cordova-coho commands for each step
Now merged by push to master