New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output current package name if package name can't be validated #567

Merged
merged 2 commits into from Nov 21, 2018

Conversation

Projects
None yet
2 participants
@janpio
Copy link
Contributor

janpio commented Nov 20, 2018

We have this of the package name. It only outputs that the current one is bad, not what the current one actually is. Added an output of the current one to the error.

Out current package name if package name can't be validated
We have this of the package name. It only outputs that the current one is bad, not what the current one actually is. Added an output of the current one to the error.
@dpogue

dpogue approved these changes Nov 20, 2018

Copy link
Member

dpogue left a comment

👍 for more useful error messages.

Note: Travis is failing due to eslint not liking the space before the closing ).
Appveyor CI is failing due to Nuget returning a 503.

@janpio janpio changed the title Out current package name if package name can't be validated Output current package name if package name can't be validated Nov 20, 2018

@dpogue dpogue merged commit a014228 into master Nov 21, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dpogue dpogue deleted the janpio-patch-1 branch Nov 21, 2018

brodybits added a commit to brodybits/cordova-android that referenced this pull request Nov 22, 2018

Output current package name if package name can't be validated (apach…
…e#567)

We have this of the package name. It only outputs that the current one
is bad, not what the current one actually is. Added an output of the
current one to the error.

@brodybits brodybits referenced this pull request Nov 22, 2018

Merged

7.1.4 patch updates #573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment