Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Device still authorizing" bug when deploying to Android emulator #630

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Fix "Device still authorizing" bug when deploying to Android emulator #630

merged 1 commit into from
Jan 18, 2019

Conversation

moose4lord
Copy link
Contributor

Fixes "Device still authorizing issue" #608 (#608)

Platforms affected

Android emulator (for versions of Android >= Oreo)

What does this PR do?

Fixes an issue with deploying a Cordova app to the Android emulator.

What testing has been done on this change?

The code fix works in my local env. I have not run any other tests.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Fixes  "Device still authorizing issue" #608 (#608)
@janpio janpio changed the title 608: (android) Fix bug when deploying to Android emulator Fix "Device still authorizing" bug when deploying to Android emulator Jan 18, 2019
@codecov-io
Copy link

Codecov Report

Merging #630 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #630   +/-   ##
=======================================
  Coverage   64.66%   64.66%           
=======================================
  Files          18       18           
  Lines        1817     1817           
=======================================
  Hits         1175     1175           
  Misses        642      642
Impacted Files Coverage Δ
bin/templates/cordova/lib/emulator.js 89.62% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a98708...39334d0. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jan 18, 2019

Codecov Report

Merging #630 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #630   +/-   ##
=======================================
  Coverage   64.66%   64.66%           
=======================================
  Files          18       18           
  Lines        1817     1817           
=======================================
  Hits         1175     1175           
  Misses        642      642
Impacted Files Coverage Δ
bin/templates/cordova/lib/emulator.js 89.62% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a98708...39334d0. Read the comment docs.

Copy link
Contributor

@brodybits brodybits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me. I hope we can get one more review before merging.

I hope this will be part of the next major release for Cordova 9 (apache/cordova#10).

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@brodybits brodybits merged commit 715ce2f into apache:master Jan 18, 2019
@brodybits
Copy link
Contributor

Thanks @moose4lord for the contribution!

Thanks @jcesarmobile for the quick review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants