Quick updates to top-level project.properties #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update header comments according to reality, in a similar fashion to bin/templates/project/project.properties * update default target API to 28 this change updates the target SDK value to 28 in both generated platforms/android/CordovaLib/AndroidManifest.xml and the resulting Android build, if not overridden by the Cordova user Co-authored-by: Christopher J. Brody <chris.brody@gmail.com> Co-authored-by: Joe Bowser <bowserj@apache.org>
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
=======================================
Coverage 64.66% 64.66%
=======================================
Files 18 18
Lines 1817 1817
=======================================
Hits 1175 1175
Misses 642 642Continue to review full report at Codecov.
|
jcesarmobile
approved these changes
Feb 8, 2019
|
Thanks @jcesarmobile for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal updates the default SDK version to 28, in both AndroidManifest.xml and the resulting APK build.
There is an additional change to update the header comments according to reality, in a similar fashion to
bin/templates/project/project.properties.