[WIP] Cleanup build.gradle defaults not used

[brodycj]

• remove defaultTargetSdkVersion which was never used
• comment out defaultBuildToolsVersion & defaultCompileSdkVersion for now

This is a quick-fix solution for #658.

[codecov-io]

Codecov Report

Merging #663 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   64.66%   64.66%           
=======================================
  Files          18       18           
  Lines        1817     1817           
=======================================
  Hits         1175     1175           
  Misses        642      642

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f30b6...6c09ea8. Read the comment docs.

[oliversalzburg]

LGTM

[janpio]

FUTURE TBD is not something that should be in the code but an issue on GitHub.

Are we sure those are not needed anywhere? Why were they here before? Did you investigate why/when they were added?

[brodycj]

FUTURE TBD is not something that should be in the code but an issue on GitHub.

Reworded, with blank lines inserted as well. I did already raise issues concerning the defaults which should be used someday in the future.

Are we sure those are not needed anywhere? Why were they here before? Did you investigate why/when they were added?

I would say yes. I did grep through the Gradle files to hopefully ensure that I got it right. Details about where and how the defaults were introduced are in issue #658.

[janpio]

Ok.

[janpio]

(I didn't actually want to approve this, as I have no idea what it could break. But I can't find a way to remove the approval without requesting changes - which I also don't want to do. Please someone else approve this before merging.)

[brodycj]

I am closing this one for now.

As I said in #655 (comment) we may still need to deal with target SDK version.

Issue #658 (default SDK values never used) remains unsolved at this point.