Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bad target+mini sdk version #680

Closed
wants to merge 1 commit into from

Conversation

neo5anderson
Copy link

Platforms affected

android

Motivation and Context

Description

change targetSdkVersion and minSdkVersion gen template.

Testing

test case has one failed, but I don't know why the sort fail, and I have nothing to do with that.
use bin/create tested, project sync fine

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #680 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #680   +/-   ##
======================================
  Coverage    64.4%   64.4%           
======================================
  Files          18      18           
  Lines        1826    1826           
======================================
  Hits         1176    1176           
  Misses        650     650

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576edb5...7d94b36. Read the comment docs.

@janpio
Copy link
Member

janpio commented Feb 22, 2019

What issue does this PR refer to?

@neo5anderson
Copy link
Author

What issue does this PR refer to?

I think it will help for #675, and it works for my projects

Copy link
Contributor

@brodybits brodybits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not so happy with the values hardcoded in several different places.

Right now the default values for the Gradle scripts are configured here:

defaultBuildToolsVersion="28.0.3" //String
defaultMinSdkVersion=19 //Integer - Minimum requirement is Android 4.4
defaultTargetSdkVersion=28 //Integer - We ALWAYS target the latest by default
defaultCompileSdkVersion=28 //Integer - We ALWAYS compile with the latest by default

I think it would be ideal if we could find a way to configure the default values in some kind of a Gradle properties file.

@brodybits
Copy link
Contributor

Thanks @neo5anderson for the contribution. I think PR #699 solves the issue in a more general purpose way.

@drastik drastik mentioned this pull request Apr 6, 2019
5 tasks
@erisu
Copy link
Member

erisu commented Apr 6, 2019

Closing out this PR as it should no longer be required with the changes of #699.

@erisu erisu closed this Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants