Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning in SystemCookieManager #710

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Apr 2, 2019

Platforms affected

Android

Motivation and Context

When building, there's a deprecation warning printed about SystemCookieManager.java uses or overrides a deprecated API.

Description

Added the correct annotation to silence the warning.

Testing

Built an app and no deprecation warning was printed.

@codecov-io
Copy link

codecov-io commented Apr 2, 2019

Codecov Report

Merging #710 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #710   +/-   ##
=======================================
  Coverage   64.38%   64.38%           
=======================================
  Files          18       18           
  Lines        1828     1828           
=======================================
  Hits         1177     1177           
  Misses        651      651

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9531dbb...908354e. Read the comment docs.

Copy link
Contributor

@brodybits brodybits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpogue dpogue added this to the 8.0.1 milestone Apr 2, 2019
@dpogue dpogue merged commit 516c341 into apache:master Apr 2, 2019
@dpogue dpogue deleted the cookie-deprecation branch April 2, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants