Do not clobber console.log to spy on it

[raphinesse]

Fix for the problem described in #778 (comment)

Properties that are replaced with spyOn are restored after each test. The manually set spies that existed previously clobbered the console.log property permanently. This broke the test output with the new reporter.

[brodybits]

LGTM and it seems to solve the problem if I introduce a test failure in my workarea.

@raphinesse do you think we need to make this kind of fix in other Cordova packages?

[raphinesse]

do you think we need to make this kind of fix in other Cordova packages?

The tests are often quite poorly written, so I wouldn't rule it out. But I would probably just fix these kinds of things when they pop up instead of starting to hunt for it now. 🤷‍♂️

[raphinesse]

Curiously, the previous code should never have caused any problems. See the last section Dot notation in the rewire docs. 😕 So I'll take back my poorly written code judgement from above 😥

Would be good to know what is going on here. I think I wrote similar code in other parts of Cordova.

[brodybits]

Interesting. I would still favor merging this change since it at least seems to be cleaner and does seem to solve the observed problem for me.

It would certainly be nice if we can understand what was going on, though.