Stop webview from restarting when activity resizes #800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
This change stops the webview from restarting when the activity window resizes while using Android's split-screen feature.
Fixes #799
Description
This change adds some new attributes to the default list of
configChanges
including:smallestScreenSize
screenLayout
uiMode
All of these will allow the webview to respond to screen changes more gracefully allowing the webview to adapt to the new change without restarting the webview or reloading the page.
Testing
I've ran
npm test
and tested on a physical Samsung Galaxy Note 9 device running Android 9.Special thanks to @ttencate for not only opening up an issue, but also providing the solution to the issue.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)