Bugfix: Fixes clean command #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpogue
approved these changes
Aug 21, 2019
timbru31
reviewed
Aug 26, 2019
| @@ -51,6 +51,8 @@ class ProjectBuilder { | |||
| buildCmd = ':app:bundleRelease'; | |||
| } else if (cmd === 'debug') { | |||
| buildCmd = ':app:bundleDebug'; | |||
| } else { | |||
There was a problem hiding this comment.
What about assigning the cmd value already to buildCmd in line 49? (i.e., let buildCmd = cmd;) This would remove the else block and only overwrite the buildCmd in the necessary debug and release cases.
There was a problem hiding this comment.
Yah I could do that for simplicity. Probably will only get a chance to make the commit tomorrow night.
There was a problem hiding this comment.
@timbru31 I've made the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Fixes the
cordova cleancommand, a reprecussion bug from #764Fixes #813
Description
Due to some code style refactoring, it became possible for the
buildCmdto stayundefined, when it used to default to the incoming parametercmdvalue. This fixesProjectBuilder.getArgsto fallback tocmdvalue if it doesn't enter in anyifconditions.Testing
npm test& manually testing.Note that at the time of working on this issue, master currently did not passnpm test. So I have "all new and existing tests pass" checkbox unchecked and checking that box is blocked by #814Checklist
(platform)if this change only applies to one platform (e.g.(android))