[Major] Removed unnecessary project name restriction

[breautek]

Platforms affected

Android

Motivation and Context

There was a condition in validateProjectName that prevented the project name from started with a number. It was found that this was added approximately 5 years ago, and it was assumed that once upon a time, this was because project names were used to generate a java class, based on the comments. However, that no longer appears to be the case.

Being able to support project names that starts with a number is important and perfectly valid (e.g: 8 Ball Pool).

It fixes #584 and fixes #701 where lots of people requested this change.

Description

Simply removed the condition preventing project names from starting with a number. validateProjectName has two other checks which were left untouched. I've also updated the comments to remove any references suggesting that successful validateProjectName calls means its safe to use the string as a java class name.

There was a unit test test for failure for project names starting with numbers which have been removed. Two items were added for the valid list for valid name checks which includes names starting with numbers.

Testing

Manual testing using:

• cordova platform add
• cordova build android
• cordova run android

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[breautek]

This PR does alter a function that is exported. While I saw no evidence that this PR will be a breaking change, there is still a possibility. Therefore this PR should only be applied on the next major (9.x)

[codecov-io]

Codecov Report

Merging #859 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
- Coverage   66.25%   66.17%   -0.08%     
==========================================
  Files          19       19              
  Lines        1843     1839       -4     
==========================================
- Hits         1221     1217       -4     
  Misses        622      622

Impacted Files	Coverage Δ
bin/lib/create.js	92.54% <ø> (-0.19%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6ad28...0e85c2d. Read the comment docs.

[raphinesse]

I left a suggestion regarding the function's JSDoc, but other than that, this LGTM 👍

[breautek]

Just a reminder that this PR should only be merged once master has been upgraded to 9.x

[timbru31]

Yes, as the [major] title suggests - side note: I only approve but leave the merging to the author of the PR (unless it's no Apache org member)

[erisu]

@breautek I think this PR is ready for merging after applying a rebase to fix the conflict.

[erisu]

👍 LGTM